Skip to content

🐛 Refactor profile deletion dialog logic #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −14
Open

🐛 Refactor profile deletion dialog logic #743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions webview-ui/src/components/ProfileManager/ProfileList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
onDuplicate: (profile: AnalysisProfile) => void;
}> = ({ profiles, selected, active, onSelect, onCreate, onDelete, onMakeActive, onDuplicate }) => {
const [openDropdownProfileId, setOpenDropdownProfileId] = React.useState<string | null>(null);
const [isDeleteDialogOpen, setIsDeleteDialogOpen] = React.useState(false);
const [profileToDelete, setProfileToDelete] = React.useState<AnalysisProfile | null>(null);

return (
<Flex direction={{ default: "column" }} spaceItems={{ default: "spaceItemsMd" }}>
Expand Down Expand Up @@ -123,9 +123,12 @@
>
Duplicate
</DropdownItem>
<DropdownItem
<DropdownItem

Check warning on line 126 in webview-ui/src/components/ProfileManager/ProfileList.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Insert `·`
key="delete"
onClick={() => setIsDeleteDialogOpen(true)}
onClick={() => {
setProfileToDelete(profile);
setIsOpen(false);
}}
isDisabled={profile.readOnly}
>
Delete
Expand All @@ -134,20 +137,22 @@
</Dropdown>
</DataListAction>
</DataListItemRow>
<ConfirmDialog
isOpen={isDeleteDialogOpen}
title="Delete profile?"
message={`Are you sure you want to delete the profile "${profile.name}"? This action cannot be undone.`}
confirmButtonText="Delete"
onConfirm={() => {
setIsDeleteDialogOpen(false);
onDelete(profile.id);
}}
onCancel={() => setIsDeleteDialogOpen(false)}
/>
</DataListItem>
);
})}
<ConfirmDialog
isOpen={profileToDelete !== null}
title="Delete profile?"
message={`Are you sure you want to delete the profile "${profileToDelete?.name}"? This action cannot be undone.`}
confirmButtonText="Delete"
onConfirm={() => {
if (profileToDelete) {
onDelete(profileToDelete.id);
}
setProfileToDelete(null);
}}
onCancel={() => setProfileToDelete(null)}
/>
</DataList>
</FlexItem>
</Flex>
Expand Down
Loading