🐛 Fix annotation matching (#149) #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tmp Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Working: Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Move in check for annotated classes Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * tmp Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Fix stuff Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Final fix Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Fix shouldVisit Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Fix condition Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Undo Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * make sure that qualification matches considers fqn usage without import and queries like (A|B|C) Signed-off-by: Pranav Gaikwad <[email protected]> * fix a minor bug in processing regex Signed-off-by: Pranav Gaikwad <[email protected]> * Fix regex Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Fix potential npe Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> --------- Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> Signed-off-by: Pranav Gaikwad <[email protected]> Co-authored-by: Pranav Gaikwad <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
/hold I think we need to handle #162 before merging |
…n. (#163) * Fixing annotation searching by getting the FQDN from the compliation. * Falls back to trying to use the code actions to get the FQDN Signed-off-by: Shawn Hurley <[email protected]> * Couple of fixes Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> * Respect annotated feature Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> --------- Signed-off-by: Shawn Hurley <[email protected]> Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> Co-authored-by: Juan Manuel Leflet Estrada <[email protected]>
shawn-hurley
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API tests PR: 354
Signed-off-by: Juan Manuel Leflet Estrada [email protected]
Signed-off-by: Pranav Gaikwad [email protected]
Co-authored-by: Pranav Gaikwad [email protected]
Signed-off-by: Cherry Picker [email protected]