Add KD tree animation #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
When traversing the tree at the end to find a nearest neighbor, one of the animations involves checking against the y-value of the split in the tree, but the language used to refer to the node's children is "left" and "right" instead of "up" and "down," which I think would be more clear. Alternatively, referencing the left/right children more explicitly in the tree itself instead of in the graph could also work and keep the language the same. I believe the next choice of which leaf node to go to also lacks any narration. I think it would be more clear with a small comment just noting which branch is taken there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KDTree.mp4