Skip to content

Conversation

@haiminh2001
Copy link

@haiminh2001 haiminh2001 commented Nov 23, 2024

Motivation

  • The earlierUseIteration (i1) is updated when i1 are not in range, including two cases: i1 is smaller than the lower bound (40m ago) and larger than the upper bound (7m ago).
  • Therefore, if a model is used continously, the earlierUseIteration (i1) will always be larger than the upper bound and will never be in range. To be scaled to 2 copies, the model has to be used once, wait for 7 minutes WITHOUT ANY other usage, if any other usage appear, it will interrupt (update the earlierUseIteration to the lastUsedIteration).

Modifications

  • Only update the earlierUseIteration if i1 is smaller than the lower bound, not when i1 is larger than the upper bound.

Results:

  • A model that is continuously used will be able to two copies, maintain the HA of that model.

Motivation:

- The earlierUseIteration (i1) is updated when i1 are not in range, including two cases: i1 is smaller than the lower bound (40m ago) and larger than the upper bound (7m ago).
- Therefore, if a model is used continously, the earlierUseIteration (i1) will always be larger than the upper bound and will never be in range. To be scaled to 2 copies, the model has to be used once, wait for 7 minutes WITHOUT ANY other usage, if any other usage appear, it will interrupt (update the earlierUseIteration to the lastUsedIteration).

Modifications:

- Only update the earlierUseIteration if i1 smaller than the lower bound, not when i1 larger than the upper bound.

Results:
- A model that is continously used will be abled to two copies, maintain the HA of that model.

Signed-off-by: haiminh2001 <[email protected]>
@Legion2
Copy link
Contributor

Legion2 commented Feb 19, 2025

Thanks for the fix, will this be part of the next release?

@spolti spolti requested review from ckadner and rafvasq February 19, 2025 16:12
@haiminh2001
Copy link
Author

@Legion2 thank you for noticing my PR, it has been around for quite a while :)). I have also applied this fix in my company 2 months ago, it works just as what I expect. If you need further elaboration on this logic, please ask. I would be so happy if this fix can be part of the next release so that I will no longer have to maintain a custom build of modelmesh in my company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants