Skip to content

Conversation

@yehudit1987
Copy link

@yehudit1987 yehudit1987 commented Sep 29, 2025

Migrate Jupyter Web App Docker publish workflow from kubeflow/kubeflow
to kubeflow/notebooks with multi-platform build improvements.

Key Changes

Migration

  • Move workflow to notebooks repo structure
  • Update image registry to ghcr.io/kubeflow/notebooks/jupyter-web-app

Successful build: https://github.com/yehudit1987/notebooks/actions/runs/18833587264/job/53729515972

Screenshot from 2025-10-27 10-33-07

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Sep 29, 2025
@google-oss-prow google-oss-prow bot added the area/backend area - related to backend components label Sep 29, 2025
@google-oss-prow google-oss-prow bot added area/ci area - related to ci area/frontend area - related to frontend components area/v1 area - version - kubeflow notebooks v1 size/M labels Sep 29, 2025
@yehudit1987 yehudit1987 force-pushed the feat/migrate_jwa_publish branch from 42977f5 to f49698e Compare September 29, 2025 17:13
@andyatmiami
Copy link
Contributor

/hold

I want to make sure:

  • we finalize the decision on container registry
  • we appropriately "seed" a package to appropriate container registry so desired permissions are in place

@yehudit1987 yehudit1987 force-pushed the feat/migrate_jwa_publish branch from f49698e to 43c1c6b Compare October 16, 2025 05:47
@yehudit1987 yehudit1987 marked this pull request as draft October 26, 2025 13:20
@yehudit1987 yehudit1987 force-pushed the feat/migrate_jwa_publish branch 3 times, most recently from 1e36649 to 91bc27c Compare October 27, 2025 08:31
@yehudit1987 yehudit1987 marked this pull request as ready for review October 27, 2025 08:34
@yehudit1987 yehudit1987 force-pushed the feat/migrate_jwa_publish branch 2 times, most recently from a08ef33 to 5c0ce13 Compare October 29, 2025 12:17
- name: Setup QEMU
uses: docker/setup-qemu-action@v3
with:
platforms: amd64,ppc64le,arm64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting but not included in the original https://github.com/kubeflow/kubeflow/blob/master/.github/workflows/jwa_docker_publish.yaml

can you comment on the benefits of adding this setting? and furthermore - could we use {{env.ARCH}} here to not have a "future sync issue" with this being separately hard-coded?

If we cannot use {{env.ARCH} outright - I'd probably suggest removing this.. but I'm still interested in understanding what prompted the inclusion!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so to be honest, I think this is leftover from some previous issues we encountered with the ARM platform. The main purpose of this step is just to specify which platforms to install, whereas the default behavior would be to set up QEMU for all platforms. Unfortunately, we can’t directly use {{env.ARCH}} here because it includes the linux/ prefix. So overall, I think the cleanest approach would be to remove this step entirely.

@andyatmiami
Copy link
Contributor

/ok-to-test

… to kubeflow/notebooks - notebooks-v1 branch

Signed-off-by: Yehudit Kerido <[email protected]>
@yehudit1987 yehudit1987 force-pushed the feat/migrate_jwa_publish branch from 5c0ce13 to 65a3f61 Compare October 30, 2025 09:11
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @yehudit1987 - good to finally be at a place to get this merged. appreciate your work!

Verified on fork:

Image available:

@google-oss-prow google-oss-prow bot added the lgtm label Oct 31, 2025
@andyatmiami
Copy link
Contributor

/unhold

@kimwnasptd
Copy link
Member

Thanks for the yet another great PR @yehudit1987!

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c7d96df into kubeflow:notebooks-v1 Oct 31, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/backend area - related to backend components area/ci area - related to ci area/frontend area - related to frontend components area/v1 area - version - kubeflow notebooks v1 lgtm ok-to-test size/M

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants