ci: Migrate kubeflow/kubeflow tb_controller_docker_publish.yaml GitHub Action to kubeflow/notebooks - notebooks-v1 branch #649
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liavweiss
force-pushed
the
migrate/kubeflow_tb_controller_docker_publish
branch
from
593db26 to
fea75b7
Compare
google-oss-prow
bot
added
area/controller
liavweiss
changed the title
…tion to kubeflow/notebooks - notebooks-v1 branch Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
liavweiss
force-pushed
the
migrate/kubeflow_tb_controller_docker_publish
branch
from
fea75b7 to
1b0a316
Compare
Member
|
Looks good @liavweiss, thanks for this! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/ok-to-test |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the GitHub Actions workflow responsible for building and publishing notebooks/tensorboard-controller images from the kubeflow/kubeflow repository to the kubeflow/notebooks repository.
Related: #620
Verification
Successful job action:
Successfully built and published notebooks/tensorboard-controller images
** The test was on my ghcr.io registry
ghcr.io/liavweiss/notebooks/tensorboard-controller/