ci: improved multi-arch build times #685
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the Dockerfiles for backend, controller, and frontend to use the `--platform=$BUILDPLATFORM` directive, enabling better compatibility for multi-platform builds. This change limits the exposure to emulation required to produce the image - ensuring the "base layer" is always built on the same architecture as the build system. This is safe: - for `controller` and `backend` because `go` build already supports cross-compilation - for `frontend` because the `webpack` config simply outputs HTML files to be including in the final state of the build. Signed-off-by: Andy Stoneberg <[email protected]>
google-oss-prow
bot
added
do-not-merge/work-in-progress
area/backend
google-oss-prow
bot
added
area/controller
Contributor
Author
|
/ok-to-test |
Member
|
Thanks for this! Will make our lives much better! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 48ae3c7
into
kubeflow:notebooks-v2
23 of 24 checks passed
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the Dockerfiles for
backend,controller, andfrontendto use the--platform=$BUILDPLATFORMdirective, enabling better compatibility for multi-platform builds.This change limits the exposure to emulation required to produce the image - ensuring the "base layer" is always built on the same architecture as the build system.
This is safe:
controllerandbackendbecausegobuild already supports cross-compilationfrontendbecause thewebpackconfig simply outputs HTML/JS files to be including in the final stage of the build.