fix: frontend Dockerfile.dev live_reload #802
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tilt's `live_reload` functionality - in addition to the `frontend` deployment's `securityContext` that drops ALL capabilities - requires a little more open permissions than we would ever configure on a production `Dockerfile` - Create app directory with correct ownership and switch to non-root user - Adjust permissions for package files and source code to support Tilt live updates Signed-off-by: Andy Stoneberg <[email protected]>
google-oss-prow
bot
added
area/frontend
Contributor
Author
|
/ok-to-test |
paulovmr
approved these changes
Dec 15, 2025
paulovmr
left a comment
paulovmr
left a comment
There was a problem hiding this comment.
@andyatmiami Nice, I've made the tilt setup in a new machine from scratch and tested the frontend live reload. All worked perfectly, great job!
/lgtm
ederign
approved these changes
Dec 15, 2025
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tilt's
live_reloadfunctionality - in addition to thefrontenddeployment'ssecurityContextthat drops ALL capabilities - requires a little more open permissions than we would ever configure on a productionDockerfileWhile generally a
chmod 777is a pretty "scary" thing to do - as Tilt is really used solely for local development - I opted for this wide open permission to maximum chance of no issues ever arising in the future.This was not properly being handled on the initial PR that introduced Tilt as called out by @thesuperzapper in his review: