fix: add --user when install python packages #136
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangallagher
changed the title
Pull Request Test Coverage Report for Build 18947333952Details
💛 - Coveralls |
9 tasks
Contributor
|
@briangallagher Thanks! /lgtm /assign @kubeflow/kubeflow-sdk-team |
kramaranya
reviewed
Oct 31, 2025
Member
|
@briangallagher Please can you rebase this PR, so we can merge it ? |
briangallagher
force-pushed
the
install-as-user
branch
from
b74f60e to
541dabd
Compare
andreyvelich
reviewed
Nov 3, 2025
Member
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
@briangallagher Please can you fix the pre-commit, so we can merge this PR ?
Signed-off-by: Brian Gallagher <[email protected]>
briangallagher
force-pushed
the
install-as-user
branch
from
541dabd to
fadb5d3
Compare
kramaranya
reviewed
Nov 4, 2025
Contributor
kramaranya
left a comment
kramaranya
left a comment
There was a problem hiding this comment.
Thank you @briangallagher!
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add --user argument when installing additional python packages to ensure avoid permissions errors when the container is running as non root
Fixes #135