ktesting: fix vmodule support #431
Open
+68
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack unwinding to determine the caller must consider the number of call levels to skip over in logr itself. This only affected the `Enabled` check and thus usage of the vmodule parameter, the actual caller then gets printed by testing.T. This also leads to a small inconsistency: the enabled check is unaware of the testing.T.Helper calls and can only check the direct caller, without skipping helpers, while the actual log output then skips the helper. There's no good fix for this, testing.T would need an API for delegating the stack unwinding to the caller (would also be useful to log a PC supplied via slog...).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-triage
k8s-ci-robot
added
size/M
Author
|
/assign @harshanarayana |
Member
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Stack unwinding to determine the caller must consider the number of call levels to skip over in logr itself. This only affected the
Enabledcheck and thus usage of the vmodule parameter, the actual caller then gets printed by testing.T.This also leads to a small inconsistency: the enabled check is unaware of the testing.T.Helper calls and can only check the direct caller, without skipping helpers, while the actual log output then skips the helper. There's no good fix for this, testing.T would need an API for delegating the stack unwinding to the caller (would also be useful to log a PC supplied via slog...).
Which issue(s) this PR fixes:
Fixes #420
Special notes for your reviewer:
One line change, multi-line unit test...
Release note: