Skip to content

Conversation

@lmktfy
Copy link
Member

@lmktfy lmktfy commented Nov 10, 2025

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Nov 10, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2025
@lmktfy
Copy link
Member Author

lmktfy commented Nov 10, 2025

/retitle Only redirect to current API docs on current site

@k8s-ci-robot k8s-ci-robot changed the title Only redirect to current API docs on current docs Only redirect to current API docs on current site Nov 10, 2025
@lmktfy lmktfy marked this pull request as draft November 10, 2025 00:38
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2025
@lmktfy lmktfy force-pushed the 20251104_redirects_only_current branch from e352696 to 24b71e3 Compare November 10, 2025 00:41
###############################################

{{/* Omit "latest" redirect for old versions of the docs */}}
{{- if not ( index .Site.params "deprecated" ) -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build is failing with following error:

12:42:33 AM: Error: error building site: render: failed to render pages: render of "home" failed: "/opt/build/repo/layouts/index.redirects:9:24": execute of template failed: template: index.redirects:9:24: executing "index.redirects" at <.Site.params>: can't evaluate field params in type page.Site

Suggested a potential fix below to see if they help with the error.

Suggested change
{{- if not ( index .Site.params "deprecated" ) -}}
{{- if not .Site.Params.deprecated -}}

Rather than have every older documentation site serve a redirect to the
current API docs, just do it for https://kubernetes.io/
@lmktfy lmktfy force-pushed the 20251104_redirects_only_current branch from 24b71e3 to 10811d9 Compare November 10, 2025 20:18
@netlify
Copy link

netlify bot commented Nov 10, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 10811d9
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6912489047b1e30008e0c48e
😎 Deploy Preview https://deploy-preview-53145--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy lmktfy marked this pull request as ready for review November 11, 2025 19:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@lmktfy lmktfy requested a review from dipesh-rawat November 11, 2025 19:24
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55509a072b22d6c119ca2b087a673064dd132f4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants