Skip to content

Conversation

@tamalsaha
Copy link
Contributor

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.

Does this PR introduce a breaking change for other components like worker-operator?


@gourishkb
Copy link
Contributor

Hey @tamalsaha did you run make build ? there are errors with your changes.

kubeslice-controller/apis/controller/v1alpha1/cluster_webhook.go:53:2: invalid field type: interface{GroupVersionKindFor(obj k8s.io/apimachinery/pkg/runtime.Object) (k8s.io/apimachinery/pkg/runtime/schema.GroupVersionKind, error); IsObjectNamespaced(obj k8s.io/apimachinery/pkg/runtime.Object) (bool, error); RESTMapper() k8s.io/apimachinery/pkg/api/meta.RESTMapper; Scheme() *k8s.io/apimachinery/pkg/runtime.Scheme; sigs.k8s.io/controller-runtime/pkg/client.Reader; sigs.k8s.io/controller-runtime/pkg/client.Writer; sigs.k8s.io/controller-runtime/pkg/client.StatusClient; sigs.k8s.io/controller-runtime/pkg/client.SubResourceClientConstructor}

@tamalsaha tamalsaha force-pushed the k132 branch 2 times, most recently from c41d9d4 to 01d76b7 Compare June 6, 2025 08:20
@tamalsaha
Copy link
Contributor Author

I was just using go install -v ./... which was working ok. make build should be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants