Fix: Equalize Status Filter and Import Cluster button sizes #2024
Conversation
|
Hi @Amank1412. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes UI inconsistency by equalizing the sizes of the "Status Filter" and "Import Cluster" buttons to improve visual alignment in the user management interface.
- Updated button styling to match dimensions between filter and import buttons
- Added hover effects for better user interaction feedback
- Adjusted padding, height, and border radius for consistent appearance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/components/its/ClustersTable/components/TableHeader.tsx | Modified Import Cluster button styling to match Status Filter button dimensions |
| frontend/src/components/admin/UserManagement.tsx | Added hover state management and border effects for filter and refresh buttons |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| color: themeStyles.colors.text.secondary, | ||
| border: `1px solid ${ | ||
| isRefreshHovered | ||
| ? (isDark ? 'rgba(59, 130, 246, 0.35)' : 'rgba(59, 130, 246, 0.2)') |
There was a problem hiding this comment.
The hover border colors for the refresh button use different opacity values (0.35 vs 0.4 for dark mode) compared to the filter button. Consider using consistent opacity values across both buttons for visual consistency.
| ? (isDark ? 'rgba(59, 130, 246, 0.35)' : 'rgba(59, 130, 246, 0.2)') | |
| ? (isDark ? 'rgba(59, 130, 246, 0.3)' : 'rgba(59, 130, 246, 0.2)') |
github-project-automation
bot
moved this from In Progress
to Done
in KubeStellar UI Project
github-project-automation
bot
moved this from Done
to In Progress
in KubeStellar UI Project
Amank1412
force-pushed
the
fix/button-size-alignment
branch
from
d6dc0a4 to
617745e
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: naman9271 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 8defa5e7c5b050393b871707437b2c298775bee7
|
|
@Amank1412 you should add a screenshot of the change so that the moderator can see the result. |
|
New changes are detected. LGTM label has been removed. |
|
@Amank1412 are you going to complete this PR? |
|
@Amank1412 Please Fix failing and update the branch with the latest changes ! |
|
Before: After: |
|
/retest |
Amank1412
force-pushed
the
fix/button-size-alignment
branch
from
83580d8 to
037d1a1
Compare
|
Sorry for delay actually i was sick |
prettier is working fine locally
|
|
@Amank1412 check in this file |
|
@Amank1412 please fix failing ? |
5 participants
This pull request fixes issue #2023 by equalizing the size of the "Status Filter" and "Import Cluster" buttons in the user management interface. The size difference caused misalignment and inconsistency in the UI.
Fixes: #2023