Skip to content

Conversation

@hhoikoo
Copy link
Member

@hhoikoo hhoikoo commented Oct 29, 2025

resolves #6427 (BA-2846)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

Copilot AI review requested due to automatic review settings October 29, 2025 04:27
@hhoikoo hhoikoo self-assigned this Oct 29, 2025
@hhoikoo hhoikoo requested a review from kyujin-cho October 29, 2025 04:27
@github-actions github-actions bot added size:XL 500~ LoC comp:agent Related to Agent component labels Oct 29, 2025
.misc.md -> 6452.misc.md

Co-authored-by: octodog <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bundles the bssh (Broadcast SSH) tool as an intrinsic binary in the Backend.AI runner package to enhance multi-node SSH capabilities within Backend.AI sessions.

  • Adds bssh binaries for both x86_64 and aarch64 architectures using Git LFS
  • Includes comprehensive bssh man page documentation
  • Implements automated binary mounting in the agent to make bssh available in containers

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ai/backend/runner/bssh.x86_64.bin x86_64 architecture bssh binary stored via Git LFS
src/ai/backend/runner/bssh.aarch64.bin aarch64 architecture bssh binary stored via Git LFS
src/ai/backend/runner/bssh.1 Complete man page documentation for bssh tool
src/ai/backend/runner/BUILD Updates build resources to include bssh man page
src/ai/backend/agent/agent.py Mounts bssh binary and man page in containers
changes/6452.misc.md News fragment documenting the bundling change
.github/workflows/import-bssh.yml Workflow for automated bssh binary updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HyeockJinKim HyeockJinKim force-pushed the main branch 4 times, most recently from 1a10632 to 2d8c9ea Compare November 23, 2025 14:45
@kyujin-cho kyujin-cho added this pull request to the merge queue Nov 27, 2025
Copy link
Member

@kyujin-cho kyujin-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Merged via the queue into main with commit b8d7fff Nov 27, 2025
28 checks passed
@kyujin-cho kyujin-cho deleted the chore/BA-2846/add-bssh branch November 27, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:agent Related to Agent component size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle bssh as intrinsic binary in Backend.AI runner package

3 participants