feat: make things work #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
jackye1995
changed the title
Remove namespace_exists, table_exists, create_table, drop_table, and register_table from Python implementations as per basic operations spec. Only required operations are kept: create_namespace, list_namespaces, describe_namespace, drop_namespace, create_empty_table (declare_table), list_tables, describe_table, and deregister_table. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Remove registerTable, namespaceExists, and tableExists from GlueNamespace as per basic operations spec. Only required operations are kept. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Remove tests for namespace_exists, table_exists, create_table, drop_table, register_table, and pyarrow conversion methods that were removed from the implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Remove tests for namespace_exists, table_exists, create_table, drop_table, and register_table from test files. These operations were removed from the implementations as per basic operations spec. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add CASCADE behavior rejection to dropNamespace for all implementations - Add load_detailed_metadata=true rejection to describeTable for all implementations - Update lance-namespace version to 0.4.2 - Rename createEmptyTable to declareTable for Iceberg - Update tests to expect InvalidInputException for CASCADE behavior - Remove non-basic operation tests from test files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Remove namespace_exists, table_exists, and register_table tests from all integration test files to align with the basic operations specification (ListNamespaces, CreateNamespace, DescribeNamespace, DropNamespace, ListTables, DeclareTable, DescribeTable, DeregisterTable). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Rename the directory to match the integration name while keeping the internal Lakekeeper container configuration unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Remove tests for namespaceExists, tableExists, and registerTable operations that were removed from the implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Unity Catalog expects 'LONG' for 64-bit integer types, not 'BIGINT'. This matches the Python implementation and fixes the integration test. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Changed from pull_request to pull_request_target so that PRs from forks can access AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY secrets configured in the upstream repository. Also simplified the workflow by removing the credential check steps. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Use AWS_REGION and AWS_S3_BUCKET_NAME secrets in workflows - Update Python and Java integration tests to use S3 paths instead of local temp directories for table locations - Tests now run against real S3 with AWS Glue 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.