refactor: remove numpy dependency by using itertools.batched/more_itertools.divide #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can see, the only reason why
lance-raydepends onnumpyis that it uses thearray_splitmethod from it.IMHO, just for one function, that's a way too huge dependency to take in. In our specific case, we're unfortunately still limited to
numpy<2.0, and thatlance-raydepends onnumpy>=2.0.0is a problem for us.I think
numpy<2.0also contained anarray_splitmethod, so in principle one could have lifted the version restriction a bit to fix our problem, but I refactored this directly a bit to not depend onnumpyat all anymore.