Skip to content

Conversation

@zhangyue19921010
Copy link
Contributor

@zhangyue19921010 zhangyue19921010 commented Dec 23, 2025

All test passed with

11:57:07.870 INFO [main] Logging.$anonfun$logInfo$1: Running Spark version 4.0.0
11:57:07.870 INFO [main] Logging.$anonfun$logInfo$1: OS info Mac OS X, 15.6.1, aarch64
11:57:07.870 INFO [main] Logging.$anonfun$logInfo$1: Java version 21.0.9

Using
mvn -Pjava21 -pl lance-spark-bundle-4.0_2.13 -am -DskipTests package
mvn -Pjava21 -pl lance-spark-4.0_2.13 -am -DskipTests package

ALSO

This PR can work with other spark version bundle like lance-spark-bundle-3.5_2.13. But it hasn't been fully tested yet, This is because Spark only officially announced support for Java 21 after Spark 4.0. https://issues.apache.org/jira/browse/SPARK-43831

mvn -Pjava21 -pl lance-spark-bundle-3.5_2.13 -am -DskipTests package

@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@github-actions github-actions bot added the enhancement New feature or request label Dec 23, 2025
@zhangyue19921010 zhangyue19921010 changed the title feat: Support java 21 with Spark 4.0 feat(spark): support Java 21 for Spark 4.0 Dec 23, 2025
@zhangyue19921010 zhangyue19921010 marked this pull request as draft December 23, 2025 06:02
@zhangyue19921010 zhangyue19921010 marked this pull request as ready for review December 23, 2025 07:13
Copy link
Collaborator

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@jackye1995 jackye1995 merged commit e7c5e9e into lance-format:main Dec 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants