Skip to content

Conversation

@jackye1995
Copy link
Contributor

@jackye1995 jackye1995 commented Jan 1, 2026

  1. Also use Default:default() for constructing request and response models so that we don't need to make change to the struct inputs every time we add new things.
  2. Leverage newly added identity to cache vended credentials
  3. Support newly added load_detailed_metadata and vend_credentials flags in requests

@github-actions github-actions bot added enhancement New feature or request python java labels Jan 1, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

Code Review

Summary: This PR upgrades lance-namespace from 0.4.0 to 0.4.3 and refactors request/response struct construction to use ..Default::default() for better forward compatibility.

Assessment: LGTM

No P0/P1 issues found. The changes are straightforward and improve maintainability.

The ..Default::default() pattern is a good practice that reduces churn when new optional fields are added to the namespace API structs.

Minor note: The #[allow(clippy::needless_update)] annotations in dir.rs:831 and manifest.rs:1371/1383 are correctly placed to suppress warnings when ..Default::default() is used on structs that currently have no additional fields - this is intentional for forward compatibility.

@jackye1995 jackye1995 changed the title feat: upgrade lance-namespace to 0.4.3 feat: upgrade lance-namespace to 0.4.5 Jan 7, 2026
@jackye1995 jackye1995 merged commit 1beb29a into lance-format:main Jan 7, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants