-
Notifications
You must be signed in to change notification settings - Fork 513
feat: refactor use of Error::io #5612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
wjones127
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this. I have several suggestions.
Feel free to suggest that we add or change an error type. For example, maybe we want to make a more general NotFound error that's separate from FileNotFound error.
|
@wjones127 i have resolved your suggestions, please review this pr again:) |
|
@lichuang Generally looks good. Can you get the code compiling and tests passing? Then I can do a final review. |
|
@wjones127 I have fixed compiling error, please run workflow, and review it again. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
@wjones127 I have fixed the test case, let's run the workflows again. |
fix #5601