Skip to content

Conversation

@lichuang
Copy link

@lichuang lichuang commented Jan 2, 2026

fix #5601

@github-actions github-actions bot added enhancement New feature or request python java labels Jan 2, 2026
@wjones127 wjones127 self-assigned this Jan 2, 2026
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. I have several suggestions.

Feel free to suggest that we add or change an error type. For example, maybe we want to make a more general NotFound error that's separate from FileNotFound error.

@lichuang
Copy link
Author

lichuang commented Jan 6, 2026

@wjones127 i have resolved your suggestions, please review this pr again:)

@wjones127
Copy link
Contributor

@lichuang Generally looks good. Can you get the code compiling and tests passing? Then I can do a final review.

@lichuang
Copy link
Author

lichuang commented Jan 8, 2026

@wjones127 I have fixed compiling error, please run workflow, and review it again.

@lichuang
Copy link
Author

lichuang commented Jan 8, 2026

@wjones127 I have fixed the test case, let's run the workflows again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review use of Error::io() to find cases where that error should be a different type

2 participants