-
Notifications
You must be signed in to change notification settings - Fork 4
Revamp contexts doc #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/geneva/jobs/contexts.mdx
Outdated
| .head_group( | ||
| service_account=service_account, | ||
| image=get_ray_image(ray_version, python_version) | ||
| image=get_ray_image(ray_version, python_version), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not strictly needed, since it will compute the default automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nice, thanks. I'll remove it from the head_group and the cpu_worker_group. It looks like you do need to provide it for the gpu_worker_group, to make sure it's a GPU image, right?
rpgreen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, bunch of minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Made a bunch of changes here to introduce Clusters, then Manifests, then execution contexts, hopefully in a more straightforward way. I wanted to make it clear that you have 3 choices for cluster, and 2 choices for how to upload your environment; I think that might not have been clear to the FE team.
See it here: https://lancedb-bcbb4faf-dantasse-contexts-again.mintlify.app/geneva/jobs/contexts