Skip to content

Conversation

@dantasse
Copy link
Contributor

@dantasse dantasse commented Jan 12, 2026

Made a bunch of changes here to introduce Clusters, then Manifests, then execution contexts, hopefully in a more straightforward way. I wanted to make it clear that you have 3 choices for cluster, and 2 choices for how to upload your environment; I think that might not have been clear to the FE team.

See it here: https://lancedb-bcbb4faf-dantasse-contexts-again.mintlify.app/geneva/jobs/contexts

.head_group(
service_account=service_account,
image=get_ray_image(ray_version, python_version)
image=get_ray_image(ray_version, python_version),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not strictly needed, since it will compute the default automatically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice, thanks. I'll remove it from the head_group and the cpu_worker_group. It looks like you do need to provide it for the gpu_worker_group, to make sure it's a GPU image, right?

Copy link
Contributor

@rpgreen rpgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, bunch of minor comments

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dantasse dantasse merged commit 849ddc0 into main Jan 15, 2026
2 checks passed
@dantasse dantasse deleted the dantasse/contexts_again branch January 15, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants