feat: geneva deployment docs using helm #83
Conversation
dantasse
left a comment
dantasse
left a comment
There was a problem hiding this comment.
Thanks Ryan!
Approving because it'd be fine if you just merged, some comments just to clarify things further.
|
|
||
| - An existing Kubernetes cluster | ||
| - An existing node pool(s) for Geneva workloads. By default, Geneva uses node selector | ||
| `{"geneva.lancedb.com/ray-head": "true"}` for Ray head nodes, and |
There was a problem hiding this comment.
I think in our GCP cluster we've got {"geneva.lancedb.com/ray-head": ""} instead of "true". (same for the worker nodes) Is that just a quirk of our setup there?
There was a problem hiding this comment.
That was fixed recently, both AWS and GCP follow this convention now
docs/geneva/deployment/helm.mdx
Outdated
|
|
||
| ## Install | ||
|
|
||
| 1. Authenticate with Kubernetes cluster |
There was a problem hiding this comment.
Sorry, this is super basic, but it's not obvious to me what this means in general. I think it means aws sso login or similar. If so, unless it's incredibly basic, want to add an example? (e.g.
1. Authenticate with Kubernetes cluster
(through your cloud service provider, like `aws sso login`, `gcp login`, or `azure login`)
There was a problem hiding this comment.
fair point, will update
| ``` | ||
| 4. Install NVIDIA device plugin (if using GPU nodes) | ||
|
|
||
| For GPU support, the NVIDIA device plugin must be installed in your EKS cluster: |
There was a problem hiding this comment.
Is this the same on GCP and Azure?
| ## Basic Kubernetes Setup | ||
|
|
||
| <Tip> | ||
| Kubernetes resources can be deployed automatically via [Helm](/geneva/deployment/helm/) or manually |
There was a problem hiding this comment.
Do we prefer the Helm installation? If so, we should say that, and probably have Helm before Manual in the sidebar. But if we don't care either way, then ignore this comment.
There was a problem hiding this comment.
Yes we do. I kept this order because the helm install does depend on some cloud resources from this section.
Co-authored-by: Dan Tasse <105866+dantasse@users.noreply.github.com>
2 participants
closes https://linear.app/lancedb/issue/GEN-269/do-a-pass-over-deployment-docs