fix(file_management): allow reading files with unknown encodings #441
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change file opening mode to ignore errors while reading. Making file reading operation to read vast file formats with different encodings. fix: This function was throwing error when trying to read file during agent operation with file format other than "utf-8"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the file-reading logic to open files in a more permissive mode so that decoding errors are ignored. This allows the agent to read a wider variety of file formats—especially those not encoded in UTF-8—without raising exceptions during tool execution.
Issue
Fixes behavior where the agent would crash while reading files containing invalid UTF-8 bytes or non-UTF-8 encodings.