-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(zhipuai): support tool calling in ChatZhipuAI #9601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| description: "illegal input in streaming mode should throw an error", | ||
| streaming: true, | ||
| temperature: 0, | ||
| temperature: -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason, ZhipuAI's API works fine with the original parameters (temperature: 0), and the test expecting an error doesn't pass any more. changed it to an invalid one therefore.
libs/langchain-community/src/chat_models/tests/chatzhipuai.int.test.ts
Outdated
Show resolved
Hide resolved
libs/langchain-community/src/chat_models/tests/chatzhipuai.int.test.ts
Outdated
Show resolved
Hide resolved
d840d17 to
9c112a8
Compare
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
This PR fixes #8211.
Changes
bindToolsmethod for ChatZhipuAI, adding support for tool calling in bothinvokeandstream.