Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-candles-share.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@langchain/openai": patch
---

fix operator precedence in reasoning initialization
5 changes: 3 additions & 2 deletions libs/langchain-openai/src/chat_models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -799,9 +799,10 @@ export abstract class BaseChatOpenAI<
this.audio = fields?.audio;
this.modalities = fields?.modalities;
this.reasoning =
fields?.reasoning ?? fields?.reasoningEffort
fields?.reasoning ??
(fields?.reasoningEffort
? { effort: fields.reasoningEffort }
: undefined;
: undefined);
this.maxTokens = fields?.maxCompletionTokens ?? fields?.maxTokens;
this.disableStreaming = fields?.disableStreaming === true;
this.streaming = fields?.streaming === true;
Expand Down
57 changes: 52 additions & 5 deletions libs/langchain-openai/src/tests/chat_models.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -574,13 +574,60 @@ describe("ChatOpenAI", () => {
});
});

test("can be constructed with reasoningEffort", async () => {
const model = new ChatOpenAI({
model: "gpt-4o-2024-08-06",
reasoningEffort: "low",
describe("reasoning field initialization", () => {
it("can be constructed with reasoningEffort", async () => {
const model = new ChatOpenAI({
model: "gpt-4o-2024-08-06",
reasoningEffort: "low",
});

expect(model.reasoning).toEqual({ effort: "low" });
});

it("can be constructed with explicit reasoning object", async () => {
const model = new ChatOpenAI({
model: "gpt-5.2-2025-12-11",
reasoning: { effort: "medium" },
});

expect(model.reasoning).toEqual({ effort: "medium" });
});

it("reasoning takes precedence over reasoningEffort", async () => {
const model = new ChatOpenAI({
model: "gpt-5.2-2025-12-11",
reasoning: { effort: "high" },
reasoningEffort: "low",
});

expect(model.reasoning).toEqual({ effort: "high" });
});

expect(model.reasoning).toEqual({ effort: "low" });
it("reasoning is undefined when neither field is provided", async () => {
const model = new ChatOpenAI({
model: "gpt-5.2-2025-12-11",
});

expect(model.reasoning).toBeUndefined();
});

it("reasoning is undefined when reasoningEffort is undefined", async () => {
const model = new ChatOpenAI({
model: "gpt-5.2-2025-12-11",
reasoningEffort: undefined,
});

expect(model.reasoning).toBeUndefined();
});

it("reasoning is undefined when reasoningEffort is null", async () => {
const model = new ChatOpenAI({
model: "gpt-5.2-2025-12-11",
reasoningEffort: null as any,
});

expect(model.reasoning).toBeUndefined();
});
});

test("specifying streaming=false disables streaming", async () => {
Expand Down
Loading