-
Notifications
You must be signed in to change notification settings - Fork 18.1k
feat: enhance annotation API to support optional message_id and content fields #27460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @liugddx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant enhancements and refactoring to the annotation creation API. The primary goal is to offer greater flexibility in how annotations are submitted, allowing users to link them directly to existing messages via a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the annotation API to make message_id optional and accept either answer or content fields for annotation content. The changes consolidate annotation creation logic by removing the deprecated endpoint in message.py and routing all annotation creation through annotation.py, while adding flexible field handling in the service layer.
Key changes:
- Updated the annotation service to accept
contentas an alias foranswerand madequestionderivable from messages - Modified the API endpoint to accept optional
message_idand flexible content fields - Removed duplicate annotation creation endpoint from message.py
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/services/annotation_service.py | Enhanced to support optional message_id, flexible answer/content fields, and automatic question derivation from messages |
| api/controllers/console/app/message.py | Removed deprecated MessageAnnotationApi endpoint and cleaned up unused imports |
| api/controllers/console/app/annotation.py | Updated to route annotation creation through the enhanced service method with optional fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the annotation creation API by moving it to its own dedicated file and enhances it to support an optional message_id and a content field as an alias for answer. The changes are well-structured, and the logic in the service layer correctly handles the new optional parameters. I've identified a couple of high-severity issues: a validation regression for message_id and a bug that prevents using empty strings for answers. Addressing these will make the implementation more robust.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Close #27401
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods