Skip to content

Conversation

@Aryansharma28
Copy link
Contributor

  • sql agent and its example

Copy link
Collaborator

@drewdrewthis drewdrewthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but I don't think we should have this on our docs without more of an explanation, and we should consider explaining how scenario handles errors.

Consider something like scenario.assert((ctx) => boolean, "Some info", { failFast: boolean})

The point being here is that maybe we want a fail-fast assertion, but I think that's a bit of anti-pattern.

if we're going to be writing Scenario tests, we should define and try to maintain what that means, maybe.

@Aryansharma28 Aryansharma28 marked this pull request as draft December 19, 2025 16:52
@Aryansharma28 Aryansharma28 marked this pull request as ready for review December 29, 2025 12:51
@Aryansharma28 Aryansharma28 merged commit 1476cdb into main Dec 29, 2025
3 checks passed
@Aryansharma28 Aryansharma28 deleted the docs/sql-agent branch December 29, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants