chore: Adds FDv2 PayloadProcessor #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
reviewed
Nov 20, 2025
| * | ||
| * @throws IllegalArgumentException if any required field is missing | ||
| */ | ||
| public void validate() { |
Member
There was a problem hiding this comment.
Ah, we have to do this because JSON makes an empty one and then fills things in?
kinyoklion
reviewed
Nov 20, 2025
| return; | ||
| } | ||
| for (Event event : events) { | ||
| if (event == null || event.getEvent() == null) { |
Member
There was a problem hiding this comment.
What is the process by which this could happen? And if it cannot happen, but does happen, then should it be silent?
kinyoklion
reviewed
Nov 20, 2025
|
|
||
| // if there's no payloads, return | ||
| List<PayloadIntent> payloads = serverIntentData.getPayloads(); | ||
| if (payloads == null || payloads.isEmpty()) { |
Member
There was a problem hiding this comment.
It feels like this may also be something we would want to know if we are diagnosing an issue.
kinyoklion
reviewed
Nov 20, 2025
| } | ||
| putObject.validate(); | ||
| // if server intent hasn't been received yet, ignore the event | ||
| if (tempId == null) { |
Member
There was a problem hiding this comment.
This was treated as an error in the Go implementation, and I also treated as an error. It feels to violate what should be a requirement of the protocol.
kinyoklion
reviewed
Nov 20, 2025
| } | ||
| payloadTransferred.validate(); | ||
| // if server intent hasn't been received yet, we should reset | ||
| if (tempId == null) { |
kinyoklion
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.