feat: Add trace based sampling for go plugin. #169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Aug 11, 2025
| sdktrace.WithResource(resources), | ||
| }, opts...) | ||
| // Only configure a sampler when there is a sampling configuration. | ||
| if sampler != nil { |
There was a problem hiding this comment.
This is different than the highlight SDK that always had a sampler with defaults.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sdk/@launchdarkly/observability-dotnet/AspSampleApp/Properties/launchSettings.json
Fixed
Show fixed
Hide fixed
sdk/@launchdarkly/observability-dotnet/AspSampleApp/Properties/launchSettings.json
Fixed
Show fixed
Hide fixed
sdk/@launchdarkly/observability-dotnet/AspSampleApp/Properties/launchSettings.json
Fixed
Show fixed
Hide fixed
sdk/@launchdarkly/observability-dotnet/AspSampleApp/Properties/launchSettings.json
Fixed
Show fixed
Hide fixed
sdk/@launchdarkly/observability-dotnet/AspSampleApp/Properties/launchSettings.json
Fixed
Show fixed
Hide fixed
kinyoklion
force-pushed
the
rlamb/o11y-384/trace-based-sampling-go
branch
from
31c4a01 to
b2e2f24
Compare
kinyoklion
force-pushed
the
rlamb/o11y-384/trace-based-sampling-go
branch
from
b2e2f24 to
77bf7df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add trace based sampling for go plugin.
Most of the code change is for testing.
How did you test this change?
Are there any deployment considerations?