[OB-75] setup packaging for @launchdarkly/observability sdks #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Vadman97
requested review from
SpennyNDaJets,
ccschmitz-launchdarkly and
mayberryzane
Vadman97
changed the title
Contributor
ccschmitz-launchdarkly
left a comment
ccschmitz-launchdarkly
left a comment
There was a problem hiding this comment.
Makes sense to me, but will leave the final approval for @kinyoklion.
Contributor
Author
|
Reviewed this offline with @kinyoklion - will merge and address follow ups as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prepare npm SDK repository for publishing using LD npm token.
https://github.com/launchdarkly/terraform/pull/18409
How did you test this change?
CI, will manually trigger action once merged
Are there any deployment considerations?
no
Does this work require review from our design team?
no
Related Jira issue: OB-75: setup packaging for @launchdarkly o11y