feat: Allow custom configuration of otel. #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Aug 20, 2025
...@launchdarkly/observability-dotnet/src/LaunchDarkly.Observability/ObservabilityExtensions.cs
Show resolved
Hide resolved
kinyoklion
commented
Aug 20, 2025
sdk/@launchdarkly/observability-dotnet/src/LaunchDarkly.Observability/DefaultNames.cs
Show resolved
Hide resolved
kinyoklion
commented
Aug 20, 2025
sdk/@launchdarkly/observability-dotnet/test/LaunchDarkly.Observability.Tests/ObserveTests.cs
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Vadman97
approved these changes
Aug 20, 2025
Merged
tanderson-ld
added a commit
that referenced
this pull request
Aug 27, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.5.0</summary> ## [0.5.0](launchdarkly-observability-android-0.4.0...launchdarkly-observability-android-0.5.0) (2025-08-26) ### Features * adds otel-android HTTP instrumentation ([#195](#195)) ([e0baf35](e0baf35)) </details> <details><summary>launchdarkly-observability-dotnet: 0.1.0</summary> ## 0.1.0 (2025-08-26) ### Features * Add basic config for dotnet plugin. ([#167](#167)) ([3203e82](3203e82)) * Add custom sampler for dotnet. ([#175](#175)) ([de74b20](de74b20)) * Add export/processor samplers. ([#178](#178)) ([2431886](2431886)) * Add graphql query to get sampling config. ([#181](#181)) ([ee51f80](ee51f80)) * Add initial plugin for dotnet. ([#173](#173)) ([564536d](564536d)) * Add singleton for dotnet. ([#185](#185)) ([c32cf1c](c32cf1c)) * Allow custom configuration of otel. ([#187](#187)) ([54e7214](54e7214)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow for the otel configuration to be customized.
How did you test this change?
Unit tests.
Manual testing.
Are there any deployment considerations?