feat: Add support for non-core ASP.Net. #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...darkly/observability-dotnet/src/LaunchDarkly.Observability/Asp/Legacy/ObservabilityPlugin.cs
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
sdk/@launchdarkly/observability-dotnet/SampleAspClassic/Areas/HelpPage/Views/Web.config
Fixed
Show fixed
Hide fixed
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kinyoklion
commented
Aug 26, 2025
...rkly/observability-dotnet/src/LaunchDarkly.Observability/Asp/Core/ObservabilityExtensions.cs
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Sep 5, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-dotnet: 0.2.0</summary> ## [0.2.0](launchdarkly-observability-dotnet-0.1.0...launchdarkly-observability-dotnet-0.2.0) (2025-09-04) ### Features * Add support for environment variable configuration. ([#205](#205)) ([5e3b1e1](5e3b1e1)) * Add support for non-core ASP.Net. ([#199](#199)) ([b215109](b215109)) ### Bug Fixes * Make attributes optional for RecordLog. ([#202](#202)) ([806ce08](806ce08)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for ASP.Net on .Net Framework.
netstandard2.0 and dotnet 8.0 support ASP.Net core.
Code that is common between the two is shared, code and dependencies that are not common are conditionally included.
How did you test this change?
Manual testing.
Are there any deployment considerations?