feat: add addSessionProperties to RecordSDK #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
addSessionPropertiesmethod to the Record SDK allowing users to callRecordSDK.addSessionPropertiesto attach metadata to sessions.How did you test this change?
Added a new E2E test page in the react router app and sent a session to staging. Note the
planandfavoriteColorproperties.Are there any deployment considerations?
Need to notify customers waiting on this functionality and open a docs PR.
Note
Introduce
addSessionPropertiesto Record SDK andLDRecord, wiring it to send session-scoped Properties messages; add unit tests and an E2E UI panel to apply properties.Record.addSessionProperties(properties)insdk/highlight-run/src/api/record.ts.RecordSDK.addSessionPropertiesto calladdProperties(..., { type: 'session' })and post aMessageType.Propertiesmessage.LDRecord.addSessionPropertiesproxy insdk/highlight-run/src/sdk/LDRecord.ts.record-add-session-properties.test.tsverifies worker postsPropertieswith{ type: 'session' }and thatLDRecordproxies correctly.e2e/react-router/src/routes/root.tsxto input JSON and callLDRecord.addSessionProperties.Written by Cursor Bugbot for commit 8d30961. This will update automatically on new commits. Configure here.