fix: support recordError with falsy Error #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Vadman97
changed the title
SpennyNDaJets
approved these changes
Oct 2, 2025
Merged
Vadman97
pushed a commit
that referenced
this pull request
Oct 3, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>observability: 0.4.4</summary> ## [0.4.4](observability-0.4.3...observability-0.4.4) (2025-10-03) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.22.1 </details> <details><summary>session-replay: 0.4.4</summary> ## [0.4.4](session-replay-0.4.3...session-replay-0.4.4) (2025-10-03) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.22.1 </details> <details><summary>highlight.run: 9.22.1</summary> ## [9.22.1](highlight.run-9.22.0...highlight.run-9.22.1) (2025-10-03) ### Bug Fixes * Add classname to user interaction ([#258](#258)) ([8ed78e1](8ed78e1)) * support recordError with falsy Error ([#253](#253)) ([8070c89](8070c89)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps `@launchdarkly/observability` and `@launchdarkly/session-replay` to 0.4.4 and `highlight.run` to 9.22.1 with minor bug fixes; updates manifest and changelogs. > > - **Releases**: > - `highlight.run` → `9.22.1` > - Bug fixes: add classname to user interaction; support `recordError` with falsy `Error`. > - `@launchdarkly/observability` → `0.4.4` > - Updates dependency to `[email protected]`. > - `@launchdarkly/session-replay` → `0.4.4` > - Updates dependency to `[email protected]`. > - **Meta**: > - Update `.release-please-manifest.json` and package changelogs to reflect new versions. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c1f9417. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support calling
LDObserve.recordErrorwith falsy value without causing an error.How did you test this change?
CI
Are there any deployment considerations?
no
Note
Ensure
recordErrorhandles nullish values by defaulting tonew Error('Unknown error').Written by Cursor Bugbot for commit d63bee4. This will update automatically on new commits. Configure here.