Skip to content

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Oct 2, 2025

Summary

Adds debugPrint instrumentation and zone configuration for normal print.

Includes some additional refactoring to account for shutting down instrumentations.

How did you test this change?

Manual testing.


Note

Adds configurable debugPrint/print instrumentation, introduces Observe/Otel shutdown and plugin registration, and updates example and exports accordingly.

  • Instrumentation:
    • Add DebugPrintInstrumentation to capture debugPrint (configurable via new InstrumentationConfig and DebugPrintSetting).
    • Extend Instrumentation interface with dispose(); make LifecycleInstrumentation.dispose() idempotent.
    • Wire instrumentation into ObservabilityPlugin (new instrumentation param) and add dispose().
  • Observe/Otel lifecycle:
    • Add Observe.shutdown() and plugin tracking; introduce registerPlugin(...).
    • Add Observe.zoneSpecification() to capture print.
    • Refactor OTEL setup into Otel class with setup()/shutdown().
  • Config/Exports:
    • Extend ObservabilityConfig to include instrumentationConfig and export InstrumentationConfig/DebugPrintSetting.
  • Example app:
    • Configure ObservabilityPlugin with InstrumentationConfig(debugPrint: DebugPrintSetting.always()).
    • Use zoneSpecification: Observe.zoneSpecification() and add buttons to trigger debugPrint/print.

Written by Cursor Bugbot for commit cdaf620. This will update automatically on new commits. Configure here.

@kinyoklion kinyoklion force-pushed the rlamb/add-debug-print-instrumentation branch from 025f022 to 30c84bc Compare October 2, 2025 15:57
@kinyoklion
Copy link
Member Author

bugbot review

cursor[bot]

This comment was marked as outdated.

@kinyoklion kinyoklion marked this pull request as ready for review October 2, 2025 21:49
@kinyoklion kinyoklion requested a review from a team as a code owner October 2, 2025 21:49
@kinyoklion kinyoklion merged commit b0f3bb1 into main Oct 6, 2025
21 checks passed
@kinyoklion kinyoklion deleted the rlamb/add-debug-print-instrumentation branch October 6, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants