fix: make sessionCookie session a boolean type #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i dont know how to approve |
ntiner1
approved these changes
Oct 16, 2025
Merged
tanderson-ld
pushed a commit
that referenced
this pull request
Oct 24, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.12.0</summary> ## [0.12.0](launchdarkly-observability-android-0.11.0...launchdarkly-observability-android-0.12.0) (2025-10-24) ### Features * Android observability plugin session replay support ([#268](#268)) ([4ba5124](4ba5124)) * O11Y-601 - Add Android launch time instrumentation ([#274](#274)) ([38b4a84](38b4a84)) </details> <details><summary>observability: 0.4.6</summary> ## [0.4.6](observability-0.4.5...observability-0.4.6) (2025-10-24) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.22.3 </details> <details><summary>session-replay: 0.4.6</summary> ## [0.4.6](session-replay-0.4.5...session-replay-0.4.6) (2025-10-24) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.22.3 </details> <details><summary>highlight.run: 9.22.3</summary> ## [9.22.3](highlight.run-9.22.2...highlight.run-9.22.3) (2025-10-24) ### Bug Fixes * avoid noisy error log on starting new sessions ([#269](#269)) ([e76004c](e76004c)) * make sessionCookie session a boolean type ([#272](#272)) ([9fb304d](9fb304d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Publish new Android, Web Observability, and Session Replay releases plus highlight.run 9.22.3 with minor features and fixes, and bump internal dependencies accordingly. > > - **SDK releases**: > - **Android (`sdk/@launchdarkly/observability-android`) 0.12.0**: > - Add session replay support in the Android observability plugin. > - Add Android launch time instrumentation. > - **Web Observability (`sdk/@launchdarkly/observability`) 0.4.6**: > - Dependency: `highlight.run` -> `9.22.3`. > - **Session Replay (`sdk/@launchdarkly/session-replay`) 0.4.6**: > - Dependency: `highlight.run` -> `9.22.3`. > - **highlight.run (`sdk/highlight-run`) 9.22.3**: > - Bug fixes: reduce noisy error log on new sessions; make `sessionCookie.session` a boolean. > - **Version manifests**: > - Update `.release-please-manifest.json` and package versions to match releases. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 1081a4c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sessionCookieoption to allowfalsefor compatibility with existing option.How did you test this change?
CI
Are there any deployment considerations?
no
Note
Change
sessionCookietype to boolean and remove duplicated option fields fromHighlightOptions.sessionCookiefromtrue-only tobooleaninsdk/highlight-run/src/client/index.tsxandsdk/highlight-run/src/client/types/types.ts.HighlightOptionsby removing redundantstorageModeandsessionCookiedeclarations (now covered inCommonOptions).Written by Cursor Bugbot for commit 69eacbf. This will update automatically on new commits. Configure here.