fix: H.stop should stop otel exporters #273
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that
H.stop()shuts down OpenTelemetry exporters.How did you test this change?
H.stop() now stops otel instrumentation; tested via e2e nextjs app
Are there any deployment considerations?
no
Note
H.stop() now flushes and shuts down OTEL tracer/meter providers; e2e app adds buttons to record a metric and start/stop.
sdk/highlight-run/src/client/index.tsx:stopRecording()now callsshutdown()to flush and stop OTEL providers.sdk/highlight-run/src/client/otel/index.ts: Refactorshutdownto run tracer/meter flush+shutdown in parallel and clear provider refs.e2e/nextjs/src/app/components/highlight-buttons.tsx: Add buttons to triggerH.recordMetric,H.start(), andH.stop().Written by Cursor Bugbot for commit 7e8e32f. This will update automatically on new commits. Configure here.