Skip to content

Conversation

@Vadman97
Copy link
Contributor

@Vadman97 Vadman97 commented Oct 15, 2025

Summary

Ensure that H.stop() shuts down OpenTelemetry exporters.

How did you test this change?

H.stop() now stops otel instrumentation; tested via e2e nextjs app

Are there any deployment considerations?

no


Note

H.stop() now flushes and shuts down OTEL tracer/meter providers; e2e app adds buttons to record a metric and start/stop.

  • SDK (client/OTEL):
    • sdk/highlight-run/src/client/index.tsx: stopRecording() now calls shutdown() to flush and stop OTEL providers.
    • sdk/highlight-run/src/client/otel/index.ts: Refactor shutdown to run tracer/meter flush+shutdown in parallel and clear provider refs.
  • E2E app:
    • e2e/nextjs/src/app/components/highlight-buttons.tsx: Add buttons to trigger H.recordMetric, H.start(), and H.stop().

Written by Cursor Bugbot for commit 7e8e32f. This will update automatically on new commits. Configure here.

@Vadman97 Vadman97 requested a review from a team as a code owner October 15, 2025 22:18
@Vadman97 Vadman97 changed the title Vadim/fix h stop otel fix: H.stop should stop otel exporters Oct 15, 2025
cursor[bot]

This comment was marked as outdated.

@Vadman97 Vadman97 enabled auto-merge (squash) October 16, 2025 22:54
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants