refactor: Reorganize existing persistent stores for better coverage #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-578/read-only-with-ds
branch
2 times, most recently
from
22b559a to
5328039
Compare
keelerm84
commented
Jan 6, 2025
| }) | ||
|
|
||
| t.Run("daemon mode", func(t *ldtest.T) { | ||
| databaseModes := map[string]servicedef.DataStoreMode{ |
There was a problem hiding this comment.
This commit reorganizes the tests to ensure we have better coverage of shared behavior.
The tests follow the pattern of:
- Run for both read only and read-write.
- Run tests for all cache configurations
- Run a set of tests without a data source
- Run a set of tests with a data source
There was a problem hiding this comment.
Thought this read out might be helpful. Repeat for consul and dynamodb.
[persistent data store/redis/uses default prefix]
[persistent data store/redis/uses custom prefix]
[persistent data store/redis/store mode read-write - no data source]
[persistent data store/redis/store mode read-write - no data source/no cache - shows changes immediately]
[persistent data store/redis/store mode read-write - no data source/ttl cache - shows changes eventually]
[persistent data store/redis/store mode read-write - no data source/infinite cache - shows changes never]
[persistent data store/redis/store mode read-write - with data source]
[persistent data store/redis/store mode read-write - with data source/no cache - ignores database until init key is set]
[persistent data store/redis/store mode read-write - with data source/no cache - ignores database when ds sends data]
[persistent data store/redis/store mode read-write - with data source/infinite cache - ignores database until init key is set]
[persistent data store/redis/store mode read-write - with data source/infinite cache - ignores database when ds sends data]
[persistent data store/redis/store mode read-write - with data source/ttl cache - ignores database until init key is set]
[persistent data store/redis/store mode read-write - with data source/ttl cache - ignores database when ds sends data]
[persistent data store/redis/store mode read - no data source]
[persistent data store/redis/store mode read - no data source/no cache - shows changes immediately]
[persistent data store/redis/store mode read - no data source/ttl cache - shows changes eventually]
[persistent data store/redis/store mode read - no data source/infinite cache - shows changes never]
[persistent data store/redis/store mode read - with data source]
[persistent data store/redis/store mode read - with data source/ttl cache - ignores database until init key is set]
[persistent data store/redis/store mode read - with data source/ttl cache - ignores database when ds sends data]
[persistent data store/redis/store mode read - with data source/no cache - ignores database until init key is set]
[persistent data store/redis/store mode read - with data source/no cache - ignores database when ds sends data]
[persistent data store/redis/store mode read - with data source/infinite cache - ignores database until init key is set]
[persistent data store/redis/store mode read - with data source/infinite cache - ignores database when ds sends data]
[persistent data store/redis/read-write]
[persistent data store/redis/read-write/initializes store when data received]
[persistent data store/redis/read-write/applies updates to store]
[persistent data store/redis/read-write/data source updates respect versioning]
[persistent data store/redis/read-write/data source deletions respect versioning]
5328039 to
6bd51db
Compare
tanderson-ld
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.