Support octal escapes as well as hexadecimal. #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dag-erling
force-pushed
the
des/octal
branch
2 times, most recently
from
4fb55f2 to
237a8bd
Compare
* Factor out the hexadecimal escape parser and rewrite it to support sequences of arbitrary length as long as they don't overflow. * Replicate the same logic for octal escapes using a `\o` prefix. * Update the unit tests and documentation accordingly.
dag-erling
force-pushed
the
des/octal
branch
from
237a8bd to
8036663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\oprefix.