Cleaned up VS2022 project and added proper x64 / ARM64 / ARM64X targets #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dag-erling
requested changes
Dec 22, 2025
Collaborator
dag-erling
left a comment
dag-erling
left a comment
There was a problem hiding this comment.
Could you please rebase after #129 goes in?
| while (n > 0) | ||
| { | ||
| consumed = tre_mbrtowc(wcptr, regex, n, &state); | ||
| consumed = (int)tre_mbrtowc(wcptr, regex, n, &state); |
Collaborator
There was a problem hiding this comment.
This should no longer be needed, #128 changed consumed to size_t.
| /* The last character wasn't complete. Let's not call it a | ||
| fatal error. */ | ||
| consumed = n; | ||
| consumed = (int)n; |
| parse_ctx.stack = stack; | ||
| parse_ctx.re = regex; | ||
| parse_ctx.len = n; | ||
| parse_ctx.len = (int)n; |
Collaborator
There was a problem hiding this comment.
This should no longer be needed once #129 goes in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up VS2022 project files that make future enhancements much easier.
Based on that, added x64 / ARM64 / ARM64EC targets.
Plus some very small changes to reduce the annoying warnings a bit.