Skip to content

Conversation

@aheissenberger
Copy link
Contributor

This is a new simplified attempt to create an adapter for AWS Lambda #30
This version supports only CDK as the deployment option.

Features:

  • streaming / buffered
  • static file routing with Cloudfront Functions / simple Routing with Cloudfront behaviors

requires #281

Copilot AI review requested due to automatic review settings November 7, 2025 01:55
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

The subject "AWS Lambda CDK deployment adapter" found in the pull request title "feat: AWS Lambda CDK deployment adapter"
didn't match the configured pattern. Please ensure that the subject
doesn't start with an uppercase character.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive test coverage and integration tests for the AWS Lambda adapter, along with test fixtures and example applications demonstrating both streaming and buffered modes.

  • Implements unit tests for adapter core components (ReactServerFramework, handlers, utilities)
  • Adds integration tests with real fixture applications to validate end-to-end Lambda deployment
  • Includes extensive debugging documentation and test infrastructure setup

Reviewed Changes

Copilot reviewed 51 out of 52 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
packages/react-server-adapter-aws-lambda/vitest.config.mjs Vitest configuration for test runner and coverage reporting
packages/react-server-adapter-aws-lambda/test/setup.mjs Global test setup with AWS Lambda runtime mocks
packages/react-server-adapter-aws-lambda/test/shared.test.mjs Unit tests for shared adapter logic and ReactServerFramework
packages/react-server-adapter-aws-lambda/test/adapter.test.mjs Tests for adapter configuration and handler path selection
packages/react-server-adapter-aws-lambda/test/utils.test.mjs Tests for CDK utility functions (static asset routing)
packages/react-server-adapter-aws-lambda/test/streaming.test.mjs Tests for streaming handler exports and initialization
packages/react-server-adapter-aws-lambda/test/streaming-timeout.integration.test.mjs Integration tests validating Lambda timeout prevention via callbackWaitsForEmptyEventLoop
packages/react-server-adapter-aws-lambda/test/integration.test.mjs Full integration tests building and executing handlers with real React Server apps
packages/react-server-adapter-aws-lambda/test/fixtures/minimal-app/* Minimal React Server app fixture with streaming support for integration testing
packages/react-server-adapter-aws-lambda/test/fixtures/minimal-app-buffered/* Minimal buffered-mode fixture for testing non-streaming Lambda handler
packages/react-server-adapter-aws-lambda/test/README.md Comprehensive testing documentation with debug logging instructions
packages/react-server-adapter-aws-lambda/package.json Package configuration with test scripts and dependencies
packages/react-server-adapter-aws-lambda/cdk/utils.mjs Utility function for generating static asset routing tables
packages/react-server-adapter-aws-lambda/README.md User-facing documentation for adapter features and configuration
examples/hello-world-aws-lambda/* Full-featured example application demonstrating AWS Lambda deployment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants