Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@igitur
Copy link
Contributor

@igitur igitur commented Sep 11, 2015

As per @eehlers 's instructions, I created the vc14 files.

@lballabio
Copy link
Owner

Thanks, but it would be best if you opened the PR on Eric's fork.

@igitur
Copy link
Contributor Author

igitur commented Sep 11, 2015

@eehlers Against which branch in your fork should I base this PR?

@eehlers
Copy link
Contributor

eehlers commented Sep 11, 2015

master please!

@igitur
Copy link
Contributor Author

igitur commented Nov 15, 2015

@eehlers Your master branch already contains the reposit change, right?

Is there another pre-reposit branch where I can create this PR against?

@igitur igitur changed the title Visual studio2015 files for QuantLibXL Visual Studio2015 files for QuantLibXL Nov 15, 2015
@igitur igitur changed the title Visual Studio2015 files for QuantLibXL Visual Studio 2015 files for QuantLibXL Nov 15, 2015
@eehlers
Copy link
Contributor

eehlers commented Nov 15, 2015

My repo is organized so that the old and new builds coexist without conflict.

The directories for the old build are unchanged:

gensrc
log4cxx
ObjectHandler
QuantLibAddin
QuantLibXL

For info, the directories for the new build are:

log4cxx
reposit
QuantLibAddin2
QuantLibXL2

But you don't need to worry about those. You can create your PR for the old build as if the new one didn't exist.

Now that I have created the v1.7.x branch I would be grateful if you could please create the PR against that.

@igitur
Copy link
Contributor Author

igitur commented Nov 16, 2015

Thanks. eehlers/QuantLib#14 created.

@lballabio
Copy link
Owner

@igitur , if you opened a PR to Eric I'd close this one. Do you agree?

@igitur
Copy link
Contributor Author

igitur commented Nov 16, 2015

Agreed.

@lballabio lballabio closed this Nov 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants