Introduce customizable error descriptions. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original one is the default, which is InlineErrorDescription. In the command line, use -i, or --inline. The second one would try to put the expected result and actual result with newlines, which is much easier to tell the difference with human eyes when the inspected string is quite long. For example, try to test a markdown formatter with a long text. In the command line, use -l, or --newline. The last one tries to put this further with external diff command. Which might not be as portable as the one in minitest, but could be already useful on most of the platforms other than Windows. In the command line, use -f, or --diff. Just try to be consistent with formatter argument, we also provide --error which you could specify Inline, Newline, or Diff, or even user provided error descriptors. However I failed to find a letter for this argument. I guess providing --error might be good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original one is the default, which is InlineErrorDescription.
In the command line, use -i, or --inline.
The second one would try to put the expected result and actual
result with newlines, which is much easier to tell the difference
with human eyes when the inspected string is quite long.
For example, try to test a markdown formatter with a long text.
In the command line, use -l, or --newline.
The last one tries to put this further with external diff command.
Which might not be as portable as the one in minitest, but could be
already useful on most of the platforms other than Windows.
In the command line, use -f, or --diff.
Just try to be consistent with formatter argument, we also provide
--error which you could specify Inline, Newline, or Diff, or even
user provided error descriptors. However I failed to find a letter
for this argument. I guess providing --error might be good enough.