Skip to content

Conversation

@euprunin
Copy link
Collaborator

@euprunin euprunin commented Dec 7, 2025


Open in Gitpod

@euprunin euprunin added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Dec 7, 2025
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 7, 2025
@github-actions
Copy link

github-actions bot commented Dec 7, 2025

PR summary dd52921e14

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
509 -1 porting notes
693 -1 erw

Current commit 8e5ce78348
Reference commit dd52921e14

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

dsimp
rw [← map_smul]
erw [smul_eq_mul, smul_eq_mul, mul_assoc] }
repeat rw [ModuleCat.restrictScalars.smul_def (M := ModuleCat.of _ _)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many repetitions do you need? Is it possible to just pass this lemma to simp as well?

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 8, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Category/ModuleCat): remove use of erw [Merged by Bors] - chore(Algebra/Category/ModuleCat): remove use of erw Dec 8, 2025
@mathlib-bors mathlib-bors bot closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants