Овсянников Никита. Технология MPI-SEQ. Подсчет числа несовпадающих символов двух строк. Вариант 27 #85
+446
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikita-Ovsyannikov
requested review from
allnes and
aobolensk
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 94.03% 94.65% +0.62%
==========================================
Files 15 17 +2
Lines 486 543 +57
Branches 181 201 +20
==========================================
+ Hits 457 514 +57
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems that your functional tests are not being executed on the CI (see the Codecov report and the Build Applications logs) |
aobolensk
reviewed
Nov 29, 2025
Comment on lines
75
to
79
| std::copy(seq_one.begin() + read_from, seq_one.begin() + read_from + part_len, main_buff.begin() + iter_pos); | ||
|
|
||
| std::copy(seq_two.begin() + read_from, seq_two.begin() + read_from + part_len, | ||
| main_buff.begin() + iter_pos + part_len); | ||
|
|
Member
There was a problem hiding this comment.
Are you sure these copies are really needed? They dramatically reduce the efficiency in your task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Чек-лист
<фамилия>_<первая_буква_имени>_<короткое_название_задачи>clang-formatлокально в моем форке (нет ошибок форматирования)clang-tidyлокально в моем форке (нет предупреждений/ошибок)nesterov_a_vector_sum), а не вmaster