add QOI Image format #1212
Open
add QOI Image format #1212
+752
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the QOI image format. Adds qoi.h as a new dependency in thirdparty/.
Contributor
|
QOI all the tings! I would like to see metadata though. The most "offical" way is to append json to the file. edit: Another thing to add, beside the encoding/decoding speedup, is the size reduction compared to stbi png. qoi should be about x0.75-x0.90 the size of stbi pngs, so always smaller. |
Author
|
I would also like to see metadata in QOI, a simple kv list or even straight up CBOR. But breaking compatibility won't help us lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR on this project!
Adds support for the QOI image format.
Adds qoi.h as a new dependency in thirdparty/.
QOI is a fast image format, according to its creator:
It losslessly compresses images to a similar size of PNG, while offering 20x-50x faster encoding and 3x-4x faster decoding.Some of us may be interested in using QOI in our pipelines/workflows. (I do and Green-Sky had expressed interest in it)
I do not write a lot of C++ so I hope this is good.
This should cover both the cli and server frontends. I have tested the cli with both input and output, I have barely tested the server, I would do more if I knew what the API is and how to interact with it :)
Note that the produced QOI files will not contain any metadata such as inference parameters, models, etc...