Skip to content

Restructure rollout storage for clarity #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Restructure rollout storage for clarity #137

wants to merge 2 commits into from
+76 −114

Conversation

@ClemensSchwarke
Copy link
Collaborator

@ClemensSchwarke ClemensSchwarke commented Nov 10, 2025 •
edited
Loading

This PR

  • moves the compute_returns function from rollout_storage to ppo.
  • removes the init_storage function from both algorithms.
  • adds minor changes to names and docstrings.

Functionality should not be influenced by these changes.

@ClemensSchwarke ClemensSchwarke marked this pull request as ready for review November 12, 2025 16:29
epalmaEth
epalmaEth requested changes Nov 13, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epalmaEth epalmaEth epalmaEth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ClemensSchwarke @epalmaEth