-
Notifications
You must be signed in to change notification settings - Fork 53
NeoEden: add initial tests #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
You sure you want to do this in one PR? I mean I'm going to help you all the way through, but my experience with that says we should do it in smaller steps |
73f2576 to
86fec04
Compare
hmm make sense, lets me rework it so we can have two eden in parallel. |
fd6c805 to
6ee8a2c
Compare
518c2d7 to
62f5dc6
Compare
The idea is to get rid of the escript and write tests using go testing infra. This is a first step twoards that goal. The main principales are 1. DRY and KISS. 2. Tests are grouped together (only smoke at the moment) 3. Tests broken into different categories based on what they test, like just EVE, or App or Network (for now just simple eve tests are ported) 5. Setup once and use in multiple tests, for example setup an app once and share it between (no-destructive) tests. Signed-off-by: Shahriyar Jalayeri <[email protected]>
62f5dc6 to
8a05029
Compare
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
2cabe15 to
1c66635
Compare
- add LogTimeErrorf - add Ubuntu 20.04 app template Signed-off-by: Shahriyar Jalayeri <[email protected]> NeoEden : rename unused paramater to _ in vtpm_test.go Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]> NeoEden : renme unused parameter to _ in template/main_test.go Signed-off-by: Shahriyar Jalayeri <[email protected]>
6c421d5 to
140c864
Compare
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
140c864 to
61307b5
Compare
|
I'm going to add the setup and teardown to this and then lets have a final round of review, I don't want to add more tests to it to bloat it more that it is. |
This is really janky at the moment, but the idea is to get rid of the escrip and write tests using go testing infra.
TODO:
Test
Simply build and prepare :
and then :