fix: 1Password CLI permissions #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes 1Password CLI credential resolution issues caused by Kubernetes fsGroup settings overriding directory permissions. The fix moves permission management from Docker build-time to runtime using a Kubernetes lifecycle hook.
- Removed Docker build-time creation of 1Password CLI config directory
- Added postStart lifecycle hook to restore required permissions after container startup
- Reformatted initScript for better readability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| staging/values.yaml | Added lifecycle hook for 1Password CLI permissions and reformatted initScript |
| build/Dockerfile | Removed build-time 1Password config directory creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Kubernetes fsGroup override broke 1Password CLI credential resolution by forcing incorrect directory permissions. Added postStart lifecycle hook to restore required permissions after container startup Validation: - Docker build passes without errors - Helm template renders correctly with lifecycle hook - Shell commands execute properly in hook Signed-off-by: Vanessa Valderrama <[email protected]>
vvalderrv
force-pushed
the
fix-1pass-dir
branch
from
c62e19d to
7a4f0c0
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes fsGroup override broke 1Password CLI credential resolution by forcing incorrect directory permissions. Added postStart lifecycle hook to restore required permissions after container startup
Validation: