Add implementation using Numpy C UFunc API #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, the tests from #1 can be used with this extension module -- but I think eventually we want to centralize the test suite and have it run against all of the implementations as a fixture.
Just to compare and contrast with #1: By using the UFunc API, this lets Numpy handle the broadcasting for us upfront, rather than handling it ourselves. I think the per-erfa-function lines-of-code is probably a little lower for this approach as well (though there is some extra helper functions at the top, we only have to get that right once).