Limit the number of outstanding IWANTs per messageid and per heartbeat. #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/limit-IWANT
branch
from
3e80860 to
e2702a7
Compare
ppopth
reviewed
Jul 3, 2025
This fixes an issue where a node would end up making an IWANT request each time a peer advertised a message with IHAVE, resulting in many duplicates for the requesting peer. The change is to limit the number of IWANT requests per message id, and to reset this limit every heartbeat. This allows fewer reqeusts
MarcoPolo
force-pushed
the
marco/limit-IWANT
branch
from
e2702a7 to
f4068ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a node would end up making an IWANT request each time a peer advertised a message with IHAVE, resulting in many duplicates for the requesting peer.
The change is to limit the number of IWANT requests per message id, and to reset this limit every heartbeat. This allows fewer reqeusts
Fixes #606